Extend predictive low alarm to Trio#680
Merged
Merged
Conversation
The low alarm's predictive look-ahead only worked with Loop, which publishes a single forecast. Trio publishes four separate forecasts (ZT, IOB, COB, UAM), so the predictive series was empty and the look-ahead never fired. Build the alarm's forward series from the lowest of the four forecasts at each point in time, so the alarm fires if any forecast dips to or below the threshold. Update the low alarm editor wording to refer to the forecast rather than to Loop's prediction. Add tests for the forecast combining and the low condition for both Loop and Trio inputs.
bjorkert
added a commit
that referenced
this pull request
Jul 8, 2026
# Conflicts: # Tests/AlarmConditions/Helpers.swift
… can fire The BG-limit gate treated the low alarm's belowBG as an activation limit, blocking evaluation until the latest reading was already at or below it, which made the predictive look-ahead unreachable. Conditions can now declare that they check their own threshold; LowBGCondition does, evaluating the latest reading, persistence, and forecast in one place.
Collaborator
Test✅ successful test Test with Loop URLFor LoopFollow tracking Loop URL:
There is no indication that this is a predictive alert. Test with Trio URLFor LoopFollow tracking Trio URL:
There is no indication that this is a predictive alert. |
marionbarker
approved these changes
Jul 20, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve from code review and test.
If we later decide to flag the reason an alert alarms (when predictive is enabled), that will be a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The low alarm's predictive look-ahead only handled Loop's single forecast. Trio publishes four separate forecasts (ZT, IOB, COB, UAM), so the predictive series was empty and the early low warning never fired.
This builds the alarm's forward series from the lowest of the four forecasts at each point in time, giving Trio an equivalent predictive-low signal: the alarm fires if any forecast dips to or below the threshold.
Note: the look-ahead was in practice broken for Loop as well. Since the 3.0 alarm rewrite, the BG-limit gate treated the low alarm's
belowBGas an activation limit and blocked evaluation until the latest reading was already at or below it, so the early warning could never fire ahead of a low (this worked in 2.x). Conditions can now declare that they check their own threshold;LowBGConditiondoes, and evaluates the latest reading, persistence, and forecast in one place.AlarmTask: newlowestForecastcombiner andalarmPredictionData, which feeds the low condition for both Loop and Trio.AlarmCondition: newchecksOwnBGLimitsso a condition can own its BG threshold instead of having it enforced as an activation limit.LowBgAlarmEditor: wording now refers to the forecast instead of Loop's prediction, and drops the "not available for Trio" note.shouldFire-level coverage of the gate.Also adds a missing
import FoundationtoSensorAgeConditionTests, which otherwise failed to compile under the current Xcode.